Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assumption on default namespace for EventType reference #7724

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Remove assumption on default namespace for EventType reference #7724

merged 4 commits into from
Feb 26, 2024

Conversation

pierDipi
Copy link
Member

Related to discussions in #7245

@pierDipi
Remove assumption on default namespace for EventType reference
ccdcd38 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 26, 2024
@knative-prow knative-prow bot requested review from aliok and creydr February 26, 2024 16:11
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
@pierDipi pierDipi requested review from Cali0707 and matzew and removed request for aliok and creydr February 26, 2024 16:11
Cali0707
Cali0707 approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for fixing my bug @pierDipi :)

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2024
@Cali0707
Copy link
Member

/cherry-pick release-1.13

@knative-prow-robot
Copy link
Contributor

@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Cali0707
Copy link
Member

/cherry-pick release-1.12

@knative-prow-robot
Copy link
Contributor

@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Cali0707
Copy link
Member

@pierDipi could you fix the two unit tests that are failing? It looks like they're expecting the namespace to be unset

@pierDipi
Add and fix tests
851de68 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Copy link
Member Author

Pushed, GH is experiencing issues https://www.githubstatus.com/ so it might be slow to update and run CI

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 69.04%. Comparing base (060c430) to head (e8c9f8e).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/apis/eventing/v1beta1/eventtype_defaults.go 25.00% 2 Missing and 1 partial ⚠️
pkg/reconciler/source/duck/duck.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7724      +/-   ##
==========================================
- Coverage   69.06%   69.04%   -0.02%     
==========================================
  Files         338      338              
  Lines       19351    19350       -1     
==========================================
- Hits        13364    13360       -4     
- Misses       5326     5328       +2     
- Partials      661      662       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cali0707
Cali0707 reviewed Feb 26, 2024
View reviewed changes
pkg/reconciler/source/duck/duck_test.go Outdated Show resolved Hide resolved
pkg/reconciler/source/duck/duck_test.go Outdated Show resolved Hide resolved
pierDipi and others added 2 commits February 26, 2024 20:37
@pierDipi @Cali0707
Update pkg/reconciler/source/duck/duck_test.go
dee82b3 
Co-authored-by: Calum Murray <cmurray@redhat.com>
@pierDipi @Cali0707
Update pkg/reconciler/source/duck/duck_test.go
e8c9f8e 
Co-authored-by: Calum Murray <cmurray@redhat.com>
Cali0707
Cali0707 approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 1160b45 into knative:main Feb 26, 2024
34 of 39 checks passed
@knative-prow-robot knative-prow-robot mentioned this pull request Feb 26, 2024
Merged
@knative-prow-robot
Copy link
Contributor

@Cali0707: new pull request created: #7725

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

@Cali0707: #7724 failed to apply on top of branch "release-1.12":

Applying: Remove assumption on default namespace for EventType reference
Using index info to reconstruct a base tree...
A	pkg/apis/eventing/v1beta3/eventtype_defaults.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/apis/http.go
CONFLICT (content): Merge conflict in pkg/apis/http.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Remove assumption on default namespace for EventType reference
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi pierDipi deleted the remove-assumption-on-default-namespace branch February 27, 2024 06:25
pierDipi added a commit to pierDipi/eventing that referenced this pull request Feb 27, 2024
@pierDipi @Cali0707
Remove assumption on default namespace for EventType reference (knati…
091c1fd 
…ve#7724)

* Remove assumption on default namespace for EventType reference

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Add and fix tests

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Update pkg/reconciler/source/duck/duck_test.go

Co-authored-by: Calum Murray <cmurray@redhat.com>

* Update pkg/reconciler/source/duck/duck_test.go

Co-authored-by: Calum Murray <cmurray@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Calum Murray <cmurray@redhat.com>
@pierDipi pierDipi mentioned this pull request Feb 27, 2024
Merged
openshift-merge-bot bot pushed a commit to openshift-knative/eventing that referenced this pull request Mar 5, 2024
@pierDipi @Cali0707
Remove assumption on default namespace for EventType reference (knati…
fa0a998 
…ve#7724) (#548)

* Remove assumption on default namespace for EventType reference



* Add and fix tests



* Update pkg/reconciler/source/duck/duck_test.go



* Update pkg/reconciler/source/duck/duck_test.go



---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Calum Murray <cmurray@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@matzew matzew Awaiting requested review from matzew

Assignees

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierDipi @Cali0707 @knative-prow-robot